hackclub/burrow
1
0
Fork 0
Code Pull requests Releases Packages Activity Actions

Detach runner launch from request timeout
Some checks are pending
Build Rust / Cargo Test (push) Waiting to run
Details
Build Site / Next.js Build (push) Waiting to run
Details

Browse source
This commit is contained in:
Conrad Kramer 2026-03-18 23:07:57 -07:00
parent 6300c661ff
commit b9fb30c18c
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
services/forgejo-nsc/internal/app/service.go
View file

@ -94,6 +94,17 @@ type RunnerHandle struct {
Name string `json:"name"`
}
func launchContext(ttl time.Duration) (context.Context, context.CancelFunc) {
if ttl <= 0 {
return context.WithTimeout(context.Background(), 2*time.Hour)
}
// Provisioning can legitimately take several minutes before the runner starts
// processing the actual Forgejo job. Keep the launch context independent from
// the caller's HTTP timeout so autoscaler/webhook requests don't kill active
// bootstraps mid-flight.
return context.WithTimeout(context.Background(), ttl+30*time.Minute)
}
func (s *Service) Dispatch(ctx context.Context, req DispatchRequest) (DispatchResponse, error) {
count := req.Count
if count <= 0 {
@ -134,7 +145,10 @@ func (s *Service) Dispatch(ctx context.Context, req DispatchRequest) (DispatchRe
return fmt.Errorf("fetching registration token: %w", err)
}
name, err := s.dispatcher.LaunchRunner(egCtx, nsc.LaunchRequest{
launchCtx, cancel := launchContext(ttl)
defer cancel()
name, err := s.dispatcher.LaunchRunner(launchCtx, nsc.LaunchRequest{
Token: token,
InstanceURL: s.instanceURL,
Labels: labels,